Move from Firebase Crash to Firebase Crashlytics and stop opt-in users #784
Conversation
|
Is this a working solution for Android? |
|
Lot of files changed..? |
|
We're using it in development for now, it seem to be working. It only connect if you initialize Firebase and Firebase's Crashlytics was enabled after using it. |
|
Do you have any code examples on initializing Firebase? |
|
No but take a look at the file : www/firebase.js exports.initFirebase = function (success, error) |
|
Thanks |
|
Can you undo your stylechanges, please? (e.g. spacing) |
|
I'll do it, but not for now, I don't have the time to. |
| </config-file> | ||
| <config-file parent="/resources" target="res/values/strings.xml"> | ||
| <string name="google_api_key">@string/google_api_key</string> | ||
| </config-file> |
There was a problem hiding this comment.
Why the removement if those values?
| }; | ||
|
|
||
| function updateStringsXml(contents) { |
There was a problem hiding this comment.
Isn't this out of scope of the PR?
|
Hi, Guillaume |
|
Hi @StephanMeijer @soumak77 could you please merge? |
|
+1 on merging |
|
Merging would be nice, indeed. |
|
+1 on merging |
|
PR has been merged and is available in v1.1.0 |
|
@soumak77 I am 99% sure this breaks crash reporting on iOS. Looking at the documentation, Crashlytics requires a build phase to be added and it isn't added. By removing the Firebase Crash framework, iOS has no working crash reporting framework. Do PRs typically have documentation updates also? By changing the behavior of the way Firebase initializes, along with the new JS APIs, this will likely cause problems when people adopt the plugin and can't understand why it isn't working. |
|
@briantq in hindsight I should have released these changes under a major release ( I don't have time to manually test every PR, so I am relying on the community to test and verify that newly released versions and proposed PRs are working as desired. Worst case, users can hardcode the version of the plugin that is working for them. I understand how annoying this can be, but that is just part of dealing with open source projects. |
|
@gvieduc could you please provide a PR with updates to the README so that others are able to understand exactly what is required to get Crashlytics working on android and iOS? It appears there are some manual steps required that are not easy to figure out. If someone else from the community could provide this info, I'll gladly accept the PR |
|
It appears this PR removed the auto-init functionality. Would any be able to help investigate and figure out what code needs to be added back to fix this? I would love to accept a PR and push out a new patch release so that those adopting v1.1.x don't have to change their code to get the plugin to work as it used to work (i.e. no breaking changes). If needed, we can add a cordova configuration variable which disables the auto-init functionality. |
|
Is the functionality in this PR still working and merged into the master-branch? cc @soumak77 |
|
@StephanMeijer yes this has been merged though it only worked on android. #836 fixed this on iOS. We still need #832 tested then I'll release a new version. |
…nesson#784 Documentation describing dependency: https://firebase.google.com/docs/android/setup
Hi,
I worked on your plugin to use Firebase Crashlytics instead of Crash because it stop on 9/9.
I succeed to use Firebase Crashlytics with Google Service and without Fabric API key.
Moreover I modified the way Firebase is initialized, opt-in is disabled by default to be GDPR compliant. Now you'll have to initialize each Firebase services to activate them so we'll can let user to choose to not use Google's services.
Lot's of files and ideas come from .
Disclaimer : I'm beginner with Cordova plugins and it's the first time I develop in Objective-C ! Every advise on the way I did this are welcome.
Thanks for reading me,
Guillaume (or William in english :) )